Re: Refactoring (was: transformExpr() refactor) - Mailing list pgsql-patches

From Alvaro Herrera
Subject Re: Refactoring (was: transformExpr() refactor)
Date
Msg-id 20050118161717.GD13418@dcc.uchile.cl
Whole thread Raw
In response to Refactoring (was: transformExpr() refactor)  (Manfred Koizar <mkoi-pg@aon.at>)
List pgsql-patches
On Tue, Jan 18, 2005 at 04:08:01PM +0100, Manfred Koizar wrote:
> On Tue, 18 Jan 2005 16:15:57 +1100, Neil Conway <neilc@samurai.com>
> wrote:
> >900 line functions are almost
> >universally bad
>
> Amen.  So you might be interested in reviewing
> http://archives.postgresql.org/pgsql-hackers/2004-06/msg00398.php ;-)

Hmm.  I think this is a good idea on principle, but what happens in case
a previous vacuum was interrupted?  Is there a possibility that tuples
belonging to that vacuum are still marked MOVED_OFF but are not in
vacpage->offsets, for example?

--
Alvaro Herrera (<alvherre[@]dcc.uchile.cl>)
"La fuerza no está en los medios físicos
sino que reside en una voluntad indomable" (Gandhi)

pgsql-patches by date:

Previous
From: Manfred Koizar
Date:
Subject: Refactoring (was: transformExpr() refactor)
Next
From: Neil Conway
Date:
Subject: test: pl/pgsql refcursors