Re: pgsql: Fix for Unicode characters above 0x10000. - Mailing list pgsql-committers

From Bruce Momjian
Subject Re: pgsql: Fix for Unicode characters above 0x10000.
Date
Msg-id 200412030048.iB30mHj28446@candle.pha.pa.us
Whole thread Raw
In response to Re: pgsql: Fix for Unicode characters above 0x10000.  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Fix for Unicode characters above 0x10000.
Re: pgsql: Fix for Unicode characters above 0x10000.
List pgsql-committers
Tom Lane wrote:
> momjian@svr1.postgresql.org (Bruce Momjian) writes:
> > Fix for Unicode characters above 0x10000.
>
> I really have to object to this going in on the day before RC1, as well.
> (1) There is no way on God's green earth that this isn't a new feature.
> (2) It is mucking with fairly central code.
> (3) AFAIK it hasn't been reviewed by anybody who's familiar with the
> multibyte code.
> (4) How do you know that wider-than-16-bit characters won't break stuff
> elsewhere?

I don't know the answers to any of these questions.  I don't even
understand the purpose of the patch.  However, no one object to it nor
did they say anything when it went into the queue, so it was applied.

If you are registering concerns, I will remove it. I was unclear about
the patch as well but assumed Unicode-folks were OK with it.

Should it be backed out and saved for 8.1?

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Fix for Unicode characters above 0x10000.
Next
From: Neil Conway
Date:
Subject: Re: pgsql: Fix for Unicode characters above 0x10000.