Re: psql \! WIN32 cleanup - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: psql \! WIN32 cleanup
Date
Msg-id 200411061755.iA6Htv112939@candle.pha.pa.us
Whole thread Raw
In response to Re: psql \! WIN32 cleanup  ("Dave Page" <dpage@vale-housing.co.uk>)
List pgsql-patches
Dave Page wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> >> The attached applied patch tests for COMSPEC in the right place and
> >> supplies a reasonable shell default on Win32.
> >>
> > + #define DEFAULT_SHELL "c:/windows/system32/cmd.exe"
>
> > Is it really a good idea to assume that the Windows installation is on
> > drive C: ?
>
> I think it's worse to assume the installation directory is "windows". On windows 2000 for example, the default is
"winnt".
> Probably the best default would simply be "cmd.exe" as it's invariably in the system path.

Agreed.  Done.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

pgsql-patches by date:

Previous
From: "Dave Page"
Date:
Subject: Re: psql \! WIN32 cleanup
Next
From: Alvaro Herrera
Date:
Subject: Re: ON COMMIT and foreign keys