Re: Problems with pgxs - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: Problems with pgxs
Date
Msg-id 200410312034.i9VKY3G00761@candle.pha.pa.us
Whole thread Raw
In response to Re: Problems with pgxs  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Problems with pgxs
List pgsql-hackers
Tom Lane wrote:
> Thomas Hallgren <thhal@mailblocks.com> writes:
> > [ Makefile.shlib contains ]
> 
> >      all-lib: all-static-lib all-shared-lib
> 
> >      all-static-lib: $(PTHREAD_H_WIN32) $(top_builddir)/src/port/pg_config_paths.h lib$(NAME).a
> 
> >      all-shared-lib: $(PTHREAD_H_WIN32) $(top_builddir)/src/port/pg_config_paths.h $(shlib)
> 
> Would someone explain to me what in the world these targets are doing
> demanding either of those as prerequisite?  They certainly did not have
> those prereqs in 7.4.  This seems an excessively klugy way of handling
> some Windows brokenness or other.

$(PTHREAD_H_WIN32) is a dependency of libpq and therefore we had to copy
it into Makefile.shlib when we are compiling from that file rather than
libpq/Makefile.  libpq/Makefile has:
 all: $(PTHREAD_H_WIN32) $(top_builddir)/src/port/pg_config_paths.h def-files all-lib

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
359-1001+  If your life is a hard drive,     |  13 Roberts Road +  Christ can be your backup.        |  Newtown Square,
Pennsylvania19073
 


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: make check error on -HEAD
Next
From: Tom Lane
Date:
Subject: Re: Using ALTER TABLESPACE in pg_dump