Re: 8.0b4: COMMIT outside of a transaction echoes ROLLBACK - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: 8.0b4: COMMIT outside of a transaction echoes ROLLBACK
Date
Msg-id 20041030190730.GA8484@surnet.cl
Whole thread Raw
In response to Re: 8.0b4: COMMIT outside of a transaction echoes ROLLBACK  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: 8.0b4: COMMIT outside of a transaction echoes ROLLBACK
List pgsql-hackers
On Wed, Oct 27, 2004 at 09:29:21PM -0400, Tom Lane wrote:
> Alvaro Herrera <alvherre@dcc.uchile.cl> writes:
> > On Wed, Oct 27, 2004 at 04:21:53PM -0400, Tom Lane wrote:
> >> On the other hand, it's also a pretty minor issue, and if it turns out
> >> to require a lot of code rejiggering to make it do that, I'd not think
> >> it worthwhile.
>
> > Patch attached.  It passes the regression tests.  It shouldn't have
> > secondary effects, but please test.
>
> Wouldn't it be better to just stay in TBLOCK_STARTED state, as if the
> COMMIT were just some random utility command?

It's the same thing, because CommitTransactionCommand acts identically
either way.  I changed it anyway because it seems simpler.

--
Alvaro Herrera (<alvherre[a]dcc.uchile.cl>)
Licensee shall have no right to use the Licensed Software
for productive or commercial use. (Licencia de StarOffice 6.0 beta)

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Charset/collate support and function parameters
Next
From: Thomas Hallgren
Date:
Subject: Re: Signature change for SPI_cursor_open