Postgres Pro
Downloads
Home   >   mailing lists

pgsql: Fix failure to think clearly about encoding conversion errors in - Mailing list pgsql-committers

From tgl@svr1.postgresql.org (Tom Lane)
Subject pgsql: Fix failure to think clearly about encoding conversion errors in
Date
Msg-id 20041029191825.487C03A3B48@svr1.postgresql.org
Whole thread Raw
List pgsql-committers
Tree view 
Log Message:
-----------
Fix failure to think clearly about encoding conversion errors in COPY.
We can't regurgitate the unconverted string as I first thought, because
the elog.c mechanisms will assume the error message data is in the server
encoding and attempt a reverse conversion.  Eventually it might be worth
providing a short-circuit path to support this, but for now the simplest
solution is to abandon trying to report back the line contents after a
conversion failure.  Per bug report from Sil Lee, 27-Oct-2004.

Modified Files:
--------------
    pgsql/src/backend/commands:
        copy.c (r1.232 -> r1.233)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/copy.c.diff?r1=1.232&r2=1.233)

pgsql-committers by date:

Previous
From: momjian@svr1.postgresql.org (Bruce Momjian)
Date:
Subject: pgsql: Set errorMessage length in PQrequestCancel() in all places.
Next
From: momjian@svr1.postgresql.org (Bruce Momjian)
Date:
Subject: pgsql: No need to set errorMessage length --- already set in goto