Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql-server: Comment out unused variable. - Mailing list pgsql-committers

From Bruce Momjian
Subject Re: pgsql-server: Comment out unused variable.
Date
Msg-id 200410050202.i9522bM02538@candle.pha.pa.us
Whole thread Raw
In response to Re: pgsql-server: Comment out unused variable.  (Neil Conway <neilc@samurai.com>)
List pgsql-committers
Tree view 
Neil Conway wrote:
> On Tue, 2004-10-05 at 01:09, Bruce Momjian wrote:
> > Log Message:
> > -----------
> > Comment out unused variable.
>
> If it is unused, it ought to be removed IMHO. Merely commenting out
> unused code leads to bloat over time.

It was part of the original NetBSD code so I usually don't remove that
stuff so the code remains a similar as possible.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

pgsql-committers by date:

Previous
From: neilc@svr1.postgresql.org (Neil Conway)
Date:
Subject: pgsql-server: Pickup fix from upstream OpenBSD sources: mark a read-only
Next
From: meskes@svr1.postgresql.org (Michael Meskes)
Date:
Subject: pgsql-server: '::' is no longer interpreted as a variable in a prepare