Re: More pgindent bizarreness - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: More pgindent bizarreness
Date
Msg-id 200409302048.i8UKmVP04156@candle.pha.pa.us
Whole thread Raw
In response to Re: More pgindent bizarreness  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: More pgindent bizarreness
List pgsql-hackers
Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > Or do you mean here?
> 
> Both, but the multi-line case with two different indent levels is
> particularly strange.
> 
> You're right that this particular code is new in 8.0.  (Looks around...)
> struct f_smgr in smgr.c is a comparable case, and it seems to have been
> weirdly indented right along, so maybe it's an old bug.

Yes, that is what I am thinking.  I have worked around other bugs in the
C code before by doing things with the shell script though this problem
seems hard to clean up with a shell script.  I found GNU indent to be
even harder to fix.

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
359-1001+  If your life is a hard drive,     |  13 Roberts Road +  Christ can be your backup.        |  Newtown Square,
Pennsylvania19073
 


pgsql-hackers by date:

Previous
From: Zhenchang Xing
Date:
Subject: output branches before infinite recursion using connectby()?
Next
From: Greg Stark
Date:
Subject: Re: Bug in Beta3 with parser?