Re: [pgsql-hackers-win32] VC++ psql build broken - Mailing list pgsql-patches

Patch applied.  Thanks.

I had removed the "/I ..\..\include\port\win32" because I thought it
wasn't needed anymore since I adjusted some include names, but I see it
is needed.

Thanks.

---------------------------------------------------------------------------


Dave Page wrote:
>
>
> > -----Original Message-----
> > From: Bruce Momjian [mailto:pgman@candle.pha.pa.us]
> > Sent: 27 September 2004 23:58
> > To: Dave Page
> > Cc: PgSQL Win32 developers; PostgreSQL Patches
> > Subject: Re: [pgsql-hackers-win32] VC++ psql build broken
> >
> >
> > I have fixed this issue with Dave's help.
>
> Hmm, not entirely it seems. An include path got missed out of the patch
> - see the attached fix. This also adds debug build support to
> src/bin/psql/win32.mak.
>
> Also:
>
> - The crash I was seeing last night appears to only occur when using
> mingw compiled libpq. Using the ones compiled with the VC++ build works
> just fine. The Windows installer puts libpq.dll and a couple of SSL libs
> in the Windows\System32 directory, so this potentially could cause some
> support emails.
>
> Strangely, pgAdmin works OK with my mingw compiled libpq.dll (with an
> import lib created from pq.def using VC++'s lib.exe), even though it is
> built with VC++ Windows. It crashes with the VC++ compiled libpq.
>
> - Compiling on a clean tree I now get the warnings below (sorry, I must
> have forgotten to try a completely clean build in my weary state last
> night :-) ):
>
> command.c
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\direct.h(132) : warning C4003: not
> enough actual parameters for macro 'mkdir'
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\signal.h(79) : warning C4005:
> 'SIG_DFL' : macro redefinition
>         ..\..\include\port/win32.h(118) : see previous definition of
> 'SIG_DFL'
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\signal.h(80) : warning C4005:
> 'SIG_IGN' : macro redefinition
>         ..\..\include\port/win32.h(120) : see previous definition of
> 'SIG_IGN'
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\signal.h(87) : warning C4005:
> 'SIG_ERR' : macro redefinition
>         ..\..\include\port/win32.h(119) : see previous definition of
> 'SIG_ERR'
> common.c
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\signal.h(79) : warning C4005:
> 'SIG_DFL' : macro redefinition
>         ..\..\include\port/win32.h(118) : see previous definition of
> 'SIG_DFL'
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\signal.h(80) : warning C4005:
> 'SIG_IGN' : macro redefinition
>         ..\..\include\port/win32.h(120) : see previous definition of
> 'SIG_IGN'
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\signal.h(87) : warning C4005:
> 'SIG_ERR' : macro redefinition
>         ..\..\include\port/win32.h(119) : see previous definition of
> 'SIG_ERR'
> common.c(536) : warning C4018: '<' : signed/unsigned mismatch
> copy.c
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\signal.h(79) : warning C4005:
> 'SIG_DFL' : macro redefinition
>         ..\..\include\port/win32.h(118) : see previous definition of
> 'SIG_DFL'
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\signal.h(80) : warning C4005:
> 'SIG_IGN' : macro redefinition
>         ..\..\include\port/win32.h(120) : see previous definition of
> 'SIG_IGN'
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\signal.h(87) : warning C4005:
> 'SIG_ERR' : macro redefinition
>         ..\..\include\port/win32.h(119) : see previous definition of
> 'SIG_ERR'
> describe.c
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\signal.h(79) : warning C4005:
> 'SIG_DFL' : macro redefinition
>         ..\..\include\port/win32.h(118) : see previous definition of
> 'SIG_DFL'
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\signal.h(80) : warning C4005:
> 'SIG_IGN' : macro redefinition
>         ..\..\include\port/win32.h(120) : see previous definition of
> 'SIG_IGN'
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\signal.h(87) : warning C4005:
> 'SIG_ERR' : macro redefinition
>         ..\..\include\port/win32.h(119) : see previous definition of
> 'SIG_ERR'
> help.c
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\signal.h(79) : warning C4005:
> 'SIG_DFL' : macro redefinition
>         ..\..\include\port/win32.h(118) : see previous definition of
> 'SIG_DFL'
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\signal.h(80) : warning C4005:
> 'SIG_IGN' : macro redefinition
>         ..\..\include\port/win32.h(120) : see previous definition of
> 'SIG_IGN'
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\signal.h(87) : warning C4005:
> 'SIG_ERR' : macro redefinition
>         ..\..\include\port/win32.h(119) : see previous definition of
> 'SIG_ERR'
> input.c
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\signal.h(79) : warning C4005:
> 'SIG_DFL' : macro redefinition
>         ..\..\include\port/win32.h(118) : see previous definition of
> 'SIG_DFL'
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\signal.h(80) : warning C4005:
> 'SIG_IGN' : macro redefinition
>         ..\..\include\port/win32.h(120) : see previous definition of
> 'SIG_IGN'
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\signal.h(87) : warning C4005:
> 'SIG_ERR' : macro redefinition
>         ..\..\include\port/win32.h(119) : see previous definition of
> 'SIG_ERR'
> large_obj.c
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\signal.h(79) : warning C4005:
> 'SIG_DFL' : macro redefinition
>         ..\..\include\port/win32.h(118) : see previous definition of
> 'SIG_DFL'
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\signal.h(80) : warning C4005:
> 'SIG_IGN' : macro redefinition
>         ..\..\include\port/win32.h(120) : see previous definition of
> 'SIG_IGN'
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\signal.h(87) : warning C4005:
> 'SIG_ERR' : macro redefinition
>         ..\..\include\port/win32.h(119) : see previous definition of
> 'SIG_ERR'
> mainloop.c
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\signal.h(79) : warning C4005:
> 'SIG_DFL' : macro redefinition
>         ..\..\include\port/win32.h(118) : see previous definition of
> 'SIG_DFL'
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\signal.h(80) : warning C4005:
> 'SIG_IGN' : macr
> o redefinition
>         ..\..\include\port/win32.h(120) : see previous definition of
> 'SIG_IGN'
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\signal.h(87) : warning C4005:
> 'SIG_ERR' : macro redefinition
>         ..\..\include\port/win32.h(119) : see previous definition of
> 'SIG_ERR'
> mainloop.c(253) : warning C4018: '==' : signed/unsigned mismatch
> mbprint.c
> print.c
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\signal.h(79) : warning C4005:
> 'SIG_DFL' : macro redefinition
>         ..\..\include\port/win32.h(118) : see previous definition of
> 'SIG_DFL'
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\signal.h(80) : warning C4005:
> 'SIG_IGN' : macro redefinition
>         ..\..\include\port/win32.h(120) : see previous definition of
> 'SIG_IGN'
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\signal.h(87) : warning C4005:
> 'SIG_ERR' : macro redefinition
>         ..\..\include\port/win32.h(119) : see previous definition of
> 'SIG_ERR'
> print.c(1238) : warning C4090: 'function' : different 'const' qualifiers
> print.c(1238) : warning C4022: 'free' : pointer mismatch for actual
> parameter 1
> print.c(1239) : warning C4090: 'function' : different 'const' qualifiers
> print.c(1239) : warning C4022: 'free' : pointer mismatch for actual
> parameter 1
> prompt.c
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\signal.h(79) : warning C4005:
> 'SIG_DFL' : macro redefinition
>         ..\..\include\port/win32.h(118) : see previous definition of
> 'SIG_DFL'
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\signal.h(80) : warning C4005:
> 'SIG_IGN' : macro redefinition
>         ..\..\include\port/win32.h(120) : see previous definition of
> 'SIG_IGN'
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\signal.h(87) : warning C4005:
> 'SIG_ERR' : macro redefinition
>         ..\..\include\port/win32.h(119) : see previous definition of
> 'SIG_ERR'
> psqlscan.c
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\signal.h(79) : warning C4005:
> 'SIG_DFL' : macro redefinition
>         ..\..\include\port/win32.h(118) : see previous definition of
> 'SIG_DFL'
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\signal.h(80) : warning C4005:
> 'SIG_IGN' : macr
> o redefinition
>         ..\..\include\port/win32.h(120) : see previous definition of
> 'SIG_IGN'
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\signal.h(87) : warning C4005:
> 'SIG_ERR' : macr
> o redefinition
>         ..\..\include\port/win32.h(119) : see previous definition of
> 'SIG_ERR'
> startup.c
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\signal.h(79) : warning C4005:
> 'SIG_DFL' : macro redefinition
>         ..\..\include\port/win32.h(118) : see previous definition of
> 'SIG_DFL'
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\signal.h(80) : warning C4005:
> 'SIG_IGN' : macro redefinition
>         ..\..\include\port/win32.h(120) : see previous definition of
> 'SIG_IGN'
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\signal.h(87) : warning C4005:
> 'SIG_ERR' : macro redefinition
>         ..\..\include\port/win32.h(119) : see previous definition of
> 'SIG_ERR'
> stringutils.c
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\signal.h(79) : warning C4005:
> 'SIG_DFL' : macro redefinition
>         ..\..\include\port/win32.h(118) : see previous definition of
> 'SIG_DFL'
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\signal.h(80) : warning C4005:
> 'SIG_IGN' : macro redefinition
>         ..\..\include\port/win32.h(120) : see previous definition of
> 'SIG_IGN'
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\signal.h(87) : warning C4005:
> 'SIG_ERR' : macro redefinition
>         ..\..\include\port/win32.h(119) : see previous definition of
> 'SIG_ERR'
> tab-complete.c
> variables.c
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\signal.h(79) : warning C4005:
> 'SIG_DFL' : macro redefinition
>         ..\..\include\port/win32.h(118) : see previous definition of
> 'SIG_DFL'
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\signal.h(80) : warning C4005:
> 'SIG_IGN' : macr
> o redefinition
>         ..\..\include\port/win32.h(120) : see previous definition of
> 'SIG_IGN'
> C:\PROGRA~1\MICROS~3\VC98\INCLUDE\signal.h(87) : warning C4005:
> 'SIG_ERR' : macro redefinition
>         ..\..\include\port/win32.h(119) : see previous definition of
> 'SIG_ERR'
>         link.exe @C:\DOCUME~1\dpage\LOCALS~1\Temp\nmh02044.
>         cd ..\..
>         echo All Win32 parts have been built!
> All Win32 parts have been built!
>
> Regards, Dave

Content-Description: win32.diff

[ Attachment, skipping... ]

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073