Re: ALTER INDEX - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: ALTER INDEX
Date
Msg-id 200408200430.i7K4Ugu13598@candle.pha.pa.us
Whole thread Raw
In response to Re: ALTER INDEX  (Stefan Kaltenbrunner <stefan@kaltenbrunner.cc>)
List pgsql-patches
I have made this adjustment.

---------------------------------------------------------------------------

Stefan Kaltenbrunner wrote:
> Gavin Sherry wrote:
>
>
> > Index: src/bin/psql/tab-complete.c
> > ===================================================================
> > RCS file: /usr/local/cvsroot/pgsql-server/src/bin/psql/tab-complete.c,v
> > retrieving revision 1.109
> > diff -2 -c -r1.109 tab-complete.c
> > *** src/bin/psql/tab-complete.c    28 Jul 2004 14:23:30 -0000    1.109
> > --- src/bin/psql/tab-complete.c    13 Aug 2004 06:34:55 -0000
> > ***************
> > *** 633,637 ****
> >       {
> >           static const char *const list_ALTER[] =
> > !         {"DATABASE", "GROUP", "SCHEMA", "TABLE", "TRIGGER", "USER", NULL};
> >
> >           COMPLETE_WITH_LIST(list_ALTER);
> > --- 633,638 ----
> >       {
> >           static const char *const list_ALTER[] =
> > !         {"DATABASE", "GROUP", "SCHEMA", "TABLE", "TRIGGER", "USER", "INDEX",
> > !              NULL};
> >
> >           COMPLETE_WITH_LIST(list_ALTER);
> > ***************
> > *** 647,650 ****
> > --- 648,661 ----
> >           COMPLETE_WITH_LIST(list_ALTERDATABASE);
> >       }
> > +     /* ALTER INDEX <name> */
> > +     else if (pg_strcasecmp(prev3_wd, "ALTER") == 0 &&
> > +              pg_strcasecmp(prev2_wd, "INDEX") == 0)
> > +     {
> > +         static const char *const list_ALTERDATABASE[] =
> > +         {"SET TABLESPACE", "OWNER TO", "RENAME TO", NULL};
> > +
> > +         COMPLETE_WITH_LIST(list_ALTERDATABASE);
>
> minor issue/nit(?): reusing list_ALTERDATABASE for the ALTER INDEX part
> looks a little strange ...
>
>
> Stefan(who could really need some feedback on his own tab-complete patch
> *g*)
>
> ---------------------------(end of broadcast)---------------------------
> TIP 1: subscribe and unsubscribe commands go to majordomo@postgresql.org
>

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: ALTER INDEX
Next
From: "Marc G. Fournier"
Date:
Subject: Re: ALTER INDEX