Re: [pgsql-hackers-win32] make fails if path has spaces - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: [pgsql-hackers-win32] make fails if path has spaces
Date
Msg-id 200408150041.i7F0fmD03555@candle.pha.pa.us
Whole thread Raw
List pgsql-patches
OK, patch attached and applied.  I am not sure if there are going to be
other place that need fixing so I added a comment.

---------------------------------------------------------------------------

Andreas Pflug wrote:
> Bruce Momjian wrote:
>
> >>>
> >>
> >>It could be fixed in both places, but the more general fix would be to
> >>qoute in Makefile.global, i.e. fixing configure.
> >
> >
> > What if you change this:
> >
> >     PERL                    = @PERL@
> >
> > to this:
> >
> >     PERL                    = "@PERL@"
> >
> > Does it help?
> >
>
> Changed in src/Makefile.global.in, and it works.
> There are other candidates that could have a non-msys path, which maybe
> should be quoted as well.
>
> Regards,
> Andreas
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 9: the planner will ignore your desire to choose an index scan if your
>       joining column's datatypes do not match
>

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
Index: src/Makefile.global.in
===================================================================
RCS file: /cvsroot/pgsql-server/src/Makefile.global.in,v
retrieving revision 1.191
diff -c -c -r1.191 Makefile.global.in
*** src/Makefile.global.in    1 Aug 2004 06:19:19 -0000    1.191
--- src/Makefile.global.in    14 Aug 2004 23:47:04 -0000
***************
*** 207,213 ****

  # Perl

! PERL            = @PERL@
  perl_archlibexp        = @perl_archlibexp@
  perl_privlibexp        = @perl_privlibexp@
  perl_useshrplib        = @perl_useshrplib@
--- 207,213 ----

  # Perl

! PERL            = "@PERL@"    # quoted for pathname with spaces
  perl_archlibexp        = @perl_archlibexp@
  perl_privlibexp        = @perl_privlibexp@
  perl_useshrplib        = @perl_useshrplib@

pgsql-patches by date:

Previous
From: "Serguei Mokhov"
Date:
Subject: Translation updates for 8.0: psql-ru
Next
From: Philip Warner
Date:
Subject: Re: [HACKERS] pg_dump 'die_on_errors'