Re: add missing options to pg_dumpall - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: add missing options to pg_dumpall
Date
Msg-id 200407192138.i6JLc0E06374@candle.pha.pa.us
Whole thread Raw
In response to Re: add missing options to pg_dumpall  (Christopher Kings-Lynne <chriskl@familyhealth.com.au>)
List pgsql-patches
Patch applied.  Thanks.

---------------------------------------------------------------------------


Christopher Kings-Lynne wrote:
> OK,
>
> Here is another patch that fixes a stack of pg_dump bugs:
>
> * Fix help text ordering
>
> * Add back --set-session-authorization to pg_dumpall.  Updated the docs
> for that.  Updated help for that.
>
> * Dump ALTER USER commands for the cluster owner ("pgsql").  These are
> dumped AFTER the create user and create database commands in case the
> permissions to do these have been revoked.
>
> * Dump ALTER OWNER for public schema (because it's possible to change
> it).  This was done by adding TOC entries for the public schema, and
> filtering them out at archiver time.  I also save the owner in the TOC
> entry just for the public schema.
>
> * Suppress dumping single quotes around schema_path and DateStyle
> options when they are set using ALTER USER or ALTER DATABASE.  Added a
> comment to the steps in guc.c to remind people to update that list.
>
> * Fix dumping in --clean mode against a pre-7.3 server.  It just sets
> all drop statements to assume the public schema, allowing it to restore
> without error.
>
> * Cleaned up text output.  eg. Don't output -- Tablespaces comment if
> there are none.  Same for groups and users.
>
> * Make the commands to DELETE FROM pg_shadow and DELETE FROM pg_group
> only be output when -c mode is enabled.  I'm not sure why that hasn't
> been done before?!?!
>
> This should be good for application asap, after which I will start on
> regression dumping 7.0-7.4 databases.
>
> Chris
>

[ application/x-gzip is not supported, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 6: Have you searched our list archives?
>
>                http://archives.postgresql.org

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [HACKERS] Point in Time Recovery
Next
From: Bruce Momjian
Date:
Subject: Re: fix schema ownership on first connection preliminary patch