Re: eventlog fix - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: eventlog fix
Date
Msg-id 200406200059.i5K0xCq19397@candle.pha.pa.us
Whole thread Raw
In response to Re: eventlog fix  ("Dave Page" <dpage@vale-housing.co.uk>)
List pgsql-patches
Dave Page wrote:
>
>
> > -----Original Message-----
> > From: Tom Lane [mailto:tgl@sss.pgh.pa.us]
> > Sent: 19 June 2004 22:49
> > To: Dave Page
> > Cc: Magnus Hagander; Bruce Momjian; Laurent Ballester;
> > pgsql-patches@postgresql.org
> > Subject: Re: [PATCHES] eventlog fix
> >
> > Hm, that is a lot ... but wouldn't the sort of people
> > interested in hacking PG on Windows likely already have it?
> >
> > If you think not, I'll withdraw my objection to keeping the
> > .BIN in CVS, but I'm just wondering whether we're worrying
> > about something that hackers would have anyway.
>
> I have mc.exe, but only because I have paid for Visual Studio. I don't
> have the platform SDK installed, however I cannot honestly say whether
> or not I would have it if I didn't have VS. I would include the file in
> CVS if it were my choice - it's clearly a pain to download the compiler
> if you don't have it, and the file is unlikely to need updating in the
> future - it was designed to be a generic DLL that just formats any
> message as '%s'.

Agreed.  We have to include the .bin file because if we don't, we would
have an additional Win32 depenency beyond Mingw.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Tablespace patch review
Next
From: Bruce Momjian
Date:
Subject: Re: Compiling libpq with VisualC