Re: [pgsql-hackers-win32] [PATCHES] Compiling libpq with VisualC - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: [pgsql-hackers-win32] [PATCHES] Compiling libpq with VisualC
Date
Msg-id 200406132357.i5DNvIZ27381@candle.pha.pa.us
Whole thread Raw
In response to Re: [PATCHES] Compiling libpq with VisualC  (pgsql@mohawksoft.com)
List pgsql-hackers
pgsql@mohawksoft.com wrote:
> >
> > [ Thread moved to hackers and win32.]
> >
> > Andreas Pflug wrote:
> >> Bruce Momjian wrote:
> >>
> >> >
> >> >
> >> >Agreed.  My pthread book says pthread_mutex_init() should be called
> >> only
> >> >once, and we have to guarantee that.  If the Windows implentation
> >> allows
> >> >it to be called multiple times, just create a function to be called
> >> only
> >> >by Win32 that does that and leave the Unix safe.
> >> >
> >> >
> >> >
> >> Ok, so here's the win32 workaround with the unix stuff left untouched.
> >> There's no memory interlocking api in win32 that wouldn't need some
> >> initializing api call itself, so we'd have to go for assembly level
> >> test-and-set code or introduce a mandatory global libpq initializing
> >> api. Considering the probably quite low usage of kerberos/ssl together
> >> with threads under win32, and the very low probability of two
> >> threads/processors (!) trying to initiate a connection at the same time,
> >> it doesn't seem to be worth the compiler hassle with assembly inline.
> >
> > What is the recommended way to create mutex objects (CreateMutex) from
> > Win32 libraries?  There must be a clean way like there is in pthreads.
>
> A mutex is inherently a global object. CreateMutex(NULL, FALSE, NULL) will
> return a handle to an unowned mutex.

Yes, but consider that two threads could both call it, with one perhaps
using the first value, and the second overwriting the first.  Obviously
not something we want.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [PATCHES] Configuration patch
Next
From: Tom Lane
Date:
Subject: Re: [PATCHES] Configuration patch