Re: pg_ctl-related "fixes" - Mailing list pgsql-committers

From Bruce Momjian
Subject Re: pg_ctl-related "fixes"
Date
Msg-id 200406012205.i51M5Qi04306@candle.pha.pa.us
Whole thread Raw
In response to Re: pg_ctl-related "fixes"  ("Serguei A. Mokhov" <mokhov@cs.concordia.ca>)
List pgsql-committers
Serguei A. Mokhov wrote:
> On Tue, 1 Jun 2004, Bruce Momjian wrote:
>
> > Date: Tue, 1 Jun 2004 16:19:05 -0400 (EDT)
> >
> > > > The first commit just did the init_nls changes while the second was all
> > > > pg_ctl.  Sorry.
> > >
> > > But the locale and NLS issues for pg_ctl still remain unfixed.
> >
> > The only thing I have not done is to add the Russian part.  pg_ctl.c
> > should have everthing it needs, right?
>
> It's missing these entirely:
>
> ***************
> *** 798,803 ****
> --- 799,810 ----
>   int
>   main(int argc, char **argv)
>   {
> + #ifdef ENABLE_NLS
> +     setlocale(LC_ALL, "");
> +     bindtextdomain(progname, LOCALEDIR);
> +     textdomain(progname);
> + #endif
> +
>       static struct option long_options[] = {
>           {"help", no_argument, NULL, '?'},
>           {"version", no_argument, NULL, 'V'},

Oops, I thought I added set_pglocale(argv[0], "pg_ctl") to pg_ctl.c, but
I think I just removed init_nls without touching pg_ctl.  Fixed now.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
? pg_ctl
Index: pg_ctl.c
===================================================================
RCS file: /cvsroot/pgsql-server/src/bin/pg_ctl/pg_ctl.c,v
retrieving revision 1.4
diff -c -c -r1.4 pg_ctl.c
*** pg_ctl.c    1 Jun 2004 03:32:42 -0000    1.4
--- pg_ctl.c    1 Jun 2004 22:03:02 -0000
***************
*** 824,829 ****
--- 824,830 ----
  #endif

      progname = get_progname(argv[0]);
+     set_pglocale(argv[0], "pg_ctl");

      /*
       * save argv[0] so do_start() can look for the postmaster if

pgsql-committers by date:

Previous
From: momjian@svr1.postgresql.org (Bruce Momjian)
Date:
Subject: pgsql-server: Add locale setting for pg_ctl.
Next
From: tgl@svr1.postgresql.org (Tom Lane)
Date:
Subject: pgsql-server: Adjust btree index build to not use shared buffers,