Re: Revert addition of -lpgport, which breaks the build - Mailing list pgsql-committers

From Bruce Momjian
Subject Re: Revert addition of -lpgport, which breaks the build
Date
Msg-id 200405211833.i4LIXjV15132@candle.pha.pa.us
Whole thread Raw
In response to Re: Revert addition of -lpgport, which breaks the build  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Revert addition of -lpgport, which breaks the build
List pgsql-committers
Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > I modified to code so only Win32 will do it.
>
> I think Neil's point is that it fails on OSX as well.  Really we have to
> do this the way libpq does, namely pull out the specific files it needs
> and recompile those with the correct shared-library-compatible CFLAGS.

Oh, that one?  Yea, I see your point. I thought you meant this from
libpq:

    ifeq ($(PORTNAME), win32)
    OBJS+=win32.o
    endif

Now I realize we are making a library and has to use the same flags.

I will make the separate build change when I return on Sunday.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

pgsql-committers by date:

Previous
From: tgl@svr1.postgresql.org (Tom Lane)
Date:
Subject: pgsql-server: Probably need sys/time.h here too to be safe.
Next
From: tgl@svr1.postgresql.org (Tom Lane)
Date:
Subject: pgsql-server: Put path configuration information into a .h file instead