Re: [HACKERS] threads stuff/UnixWare - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: [HACKERS] threads stuff/UnixWare
Date
Msg-id 200405132357.i4DNv9E25053@candle.pha.pa.us
Whole thread Raw
In response to Re: [HACKERS] threads stuff/UnixWare  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [HACKERS] threads stuff/UnixWare  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > *** src/Makefile.global.in    11 May 2004 21:57:14 -0000    1.182
> > --- src/Makefile.global.in    13 May 2004 23:03:12 -0000
> > ***************
> > *** 177,182 ****
> > --- 177,188 ----
> >     CFLAGS += -Wall -Wmissing-prototypes -Wmissing-declarations
> >   endif
>
> > + # Unixware needs threads for everything that uses libpq
> > + ifeq ($(PORTNAME),unixware)
> > +   CFLAGS += "$PTHREAD_CFLAGS"
> > + endif
> > +
> > +
> >   # Kind-of compilers
>
> >   YACC = @YACC@
>
>
> Yech.  Isn't this what the Makefile.port files are for?  Makefile.global
> should never contain any "#ifdef port" junk.

So we just add the thing in the template file?  Yea, I can do that.  I
did it there because Win32 already had something for libs.  Does the
template file get included in Makefile.global?  I didn't think so.

Part of the problem is we don't know if they have asked for threads at
the time we load the template file from configure, no?

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

pgsql-patches by date:

Previous
From: Larry Rosenman
Date:
Subject: Re: [HACKERS] threads stuff/UnixWare
Next
From: Tom Lane
Date:
Subject: Re: [HACKERS] threads stuff/UnixWare