Re: mingw regression test fixes - Mailing list pgsql-patches

From Peter Eisentraut
Subject Re: mingw regression test fixes
Date
Msg-id 200405022217.51229.peter_e@gmx.net
Whole thread Raw
In response to Re: mingw regression test fixes  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: mingw regression test fixes  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-patches
Bruce Momjian wrote:
> OK, I have made this adjustment.  Thanks.

$build_platform would be more correct.  It keeps everything consistent.

>
> ---------------------------------------------------------------------
>------
>
> Andrew Dunstan wrote:
> > Claudio Natoli said:
> > > For application to HEAD.
> > >
> > > As Andrew Dunstan appears to have cracked the regression test
> > > buffering nut, this patch makes sure that:
> > > * correct platform specific regression files are used under ming
> > > * pwd prints out a usable win32 pathname
> >
> > Claudio,
> >
> > I'm assuming that you have checked that this works, as it is
> > slightly different from what I did.
> >
> > Strictly speaking, the pwd flags test should probably depend in the
> > test platform rather than the target platform. Something like:
> >
> >  case `uname` in
> >      MINGW32*)
> >          PWDFLAGS=-W;;
> >      *)
> >          PWDFLAGS=;;
> >  esac
> >
> > I made that adjustment to what I was doing late in the day, but
> > didn't have time to do a revised patch before I had to do other
> > things.
> >
> > cheers
> >
> > andrew
> >
> >
> >
> >
> > ---------------------------(end of
> > broadcast)--------------------------- TIP 7: don't forget to
> > increase your free space map settings


pgsql-patches by date:

Previous
From: Fabien COELHO
Date:
Subject: new aggregate functions v2
Next
From: Bruce Momjian
Date:
Subject: Re: mingw regression test fixes