Re: listening addresses - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: listening addresses
Date
Msg-id 200403240407.i2O47lC08366@candle.pha.pa.us
Whole thread Raw
In response to Re: listening addresses  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: listening addresses
List pgsql-patches
Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
> > Second attempt attached. The fatal message now reads "no configured
> > listening socket available", but I am not wedded to the wording. I also
> > was not sure how to mark up * in the docs.
>
> Reviewed and committed.
>
> I found a bunch more references in the docs to the postmaster -i and -h
> switches, and I'm far from sure we've hit them all yet; anyone want to
> make another pass to check?
>
> Code-wise it looked great, except that you need to remember to cast the
> argument of isspace() to unsigned char; on most machines with signed
> chars, failing to do this causes big trouble for 8th-bit-set characters.
>
> I went with "no socket configured to listen on" for the failure message,
> but am not wedded to that either.

I updated the error text to:

            (errmsg("no socket configured for listening")));

Hope you like it.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Patch for select and APC on win32
Next
From: "Andrew Dunstan"
Date:
Subject: Re: listening addresses