Re: pstrndup() - Mailing list pgsql-patches

From Karel Zak
Subject Re: pstrndup()
Date
Msg-id 20040323101052.GA32767@zf.jcu.cz
Whole thread Raw
In response to Re: pstrndup()  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pstrndup()  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-patches
On Mon, Mar 22, 2004 at 10:04:01AM -0500, Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > Karel Zak wrote:
> >> The result of  strndup() is always zero terminated. It's  more safe and
> >> strndup() is  binary safe because  it doesn't check something  in input
> >> string. The pstrndup() is based on PostgreSQL memory managment.
>
> > Can you find places to use this function our backend?  Seems that should
> > be part of the patch.
>
> A bit of googling showed that strndup does appear in the "Linux
> standards base", but it is not to be found in the Single Unix Spec.
> That makes it at most quasi-standard IMHO.

 man strndup

CONFORMING TO
     SVID 3, BSD 4.3

> with strncpy).  That's a lot of strikes for something that replaces only
> three lines of C ...

 How often are bugs with "add '\0' to last item of array"?

 Well, forget this patch...

    Karel

--
 Karel Zak  <zakkr@zf.jcu.cz>
 http://home.zf.jcu.cz/~zakkr/

pgsql-patches by date:

Previous
From: "Magnus Hagander"
Date:
Subject: Re: Patch for select and APC on win32
Next
From: Claudio Natoli
Date:
Subject: Re: Patch for select and APC on win32