Re: pstrndup() - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: pstrndup()
Date
Msg-id 200403221448.i2MEmfp01284@candle.pha.pa.us
Whole thread Raw
In response to Re: pstrndup()  (Karel Zak <zakkr@zf.jcu.cz>)
Responses Re: pstrndup()
List pgsql-patches
Karel Zak wrote:
> On Sun, Mar 21, 2004 at 11:45:18PM -0500, Tom Lane wrote:
> > Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > > Karel, do you plan to use pstrndup for some purpose?  I assume so.
>
>  I   think    PostgreSQL   should   supports   basic    operation   with
>  allocation/strings if  it's open for  users' C functions and  we expect
>  our own memory system usage.
>
> > I am not familiar with strndup.  If the spec is like strncpy, I would
> > vote against including it ... strncpy is so broken that we had to invent
> > our own variant ...
>
>  POSIX strncpy()  is different,  a result from  strncpy needn't  be zero
>  terminated. You're right it's horrible function.
>
>  The result of  strndup() is always zero terminated. It's  more safe and
>  strndup() is  binary safe because  it doesn't check something  in input
>  string. The pstrndup() is based on PostgreSQL memory managment.

Can you find places to use this function our backend?  Seems that should
be part of the patch.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

pgsql-patches by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: [HACKERS] listening addresses
Next
From: Tom Lane
Date:
Subject: Re: pstrndup()