Re: Removal of win32-specific rename code - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: Removal of win32-specific rename code
Date
Msg-id 200403161323.i2GDNCB05699@candle.pha.pa.us
Whole thread Raw
In response to Re: Removal of win32-specific rename code  (Claudio Natoli <claudio.natoli@memetrics.com>)
List pgsql-patches
Claudio Natoli wrote:
>
> > main file.  WIth Claudio's fix, this isn't necessary.
>
> Bruce, are you sure this is true? The fix is only for files than are
> open()'d, not fopen()'d (as per AllocateFile).

If your fix works, I will change the Win32-specific code to use open()
and fdopen().  The only advantage to the old code was that it would
release locks, then go into a rename loop, which is horid, and we need
to avoid the loop.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

pgsql-patches by date:

Previous
From: Claudio Natoli
Date:
Subject: Re: Removal of win32-specific rename code
Next
From: Fabien COELHO
Date:
Subject: hint infrastructure setup (v2)