Re: fork/exec patch: pre-CreateProcess finalization - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: fork/exec patch: pre-CreateProcess finalization
Date
Msg-id 200401092326.i09NQuF26149@candle.pha.pa.us
Whole thread Raw
In response to Re: fork/exec patch: pre-CreateProcess finalization  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
Done and attached.

---------------------------------------------------------------------------

Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > Claudio specified the attached fix, which I have applied (this time).
>
> The ereport must vanish back into its black hole, also.
> ProcessStartupPacket has already issued any appropriate log message.
>
> > *** 2450,2456 ****
> >       {
> >           ereport(LOG,
> >                   (errmsg("connection startup failed")));
> > !         proc_exit(status);
> >       }
>
> >       /*
> > --- 2450,2456 ----
> >       {
> >           ereport(LOG,
> >                   (errmsg("connection startup failed")));
> > !         proc_exit(0);
> >       }
>
> >       /*
>
>             regards, tom lane
>

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
Index: src/backend/postmaster/postmaster.c
===================================================================
RCS file: /cvsroot/pgsql-server/src/backend/postmaster/postmaster.c,v
retrieving revision 1.356
diff -c -c -r1.356 postmaster.c
*** src/backend/postmaster/postmaster.c    9 Jan 2004 23:11:39 -0000    1.356
--- src/backend/postmaster/postmaster.c    9 Jan 2004 23:25:36 -0000
***************
*** 2447,2457 ****
      status = ProcessStartupPacket(port, false);

      if (status != STATUS_OK)
-     {
-         ereport(LOG,
-                 (errmsg("connection startup failed")));
          proc_exit(0);
-     }

      /*
       * Now that we have the user and database name, we can set the process
--- 2447,2453 ----

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: fork/exec patch: pre-CreateProcess finalization
Next
From: Bruce Momjian
Date:
Subject: BEGIN WORK and transaction isolation level