Re: Alpha test - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: Alpha test
Date
Msg-id 200312230057.hBN0vE918520@candle.pha.pa.us
Whole thread Raw
In response to Re: Alpha test  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Alpha test
List pgsql-patches
Tom Lane wrote:
> Alvaro Herrera <alvherre@dcc.uchile.cl> writes:
> > On Mon, Dec 22, 2003 at 06:36:32PM -0500, Bruce Momjian wrote:
> >> Seems we have to test for __alpha and __alpha_.  This applied patch
> >> makes that consistent.
>
> > Won't something like the following work?
>
> > #ifdef(__alpha)
> > #define __alpha__ 1
> > #endif
>
> It seems risky to me to define macros that are in the
> reserved-for-system-use namespace.  Who knows what might break in the
> system headers if we did that?

I see we already do this in solaris.h:

    #if defined(__i386) && !defined(__i386__)
    #define __i386__
    #endif

    #if defined(__sparc) && !defined(__sparc__)
    #define __sparc__
    #endif

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: Alpha test
Next
From: Bruce Momjian
Date:
Subject: Move slock_t defines into s_lock.h