Re: introduce "default_use_oids" - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: introduce "default_use_oids"
Date
Msg-id 200312011412.hB1EC4R02668@candle.pha.pa.us
Whole thread Raw
In response to Re: introduce "default_use_oids"  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-patches
Agreed.

---------------------------------------------------------------------------

Peter Eisentraut wrote:
> Bruce Momjian writes:
>
> > Your patch has been added to the PostgreSQL unapplied patches list at:
> >
> >     http://momjian.postgresql.org/cgi-bin/pgpatches
> >
> > I will try to apply it within the next 48 hours.
>
> This parameter ought to be called "default_with_oids", to reflect the
> actual effect.
>
> >
> > ---------------------------------------------------------------------------
> >
> >
> > Neil Conway wrote:
> > > On Fri, 2003-10-10 at 05:56, Manfred Koizar wrote:
> > > > On Tue, 30 Sep 2003 20:00:22 -0400, Neil Conway <neilc@samurai.com>
> > > > wrote:
> > > > >This patch adds a new GUC var, "default_use_oids"
> > > >
> > > > Shouldn't it be honoured by CREATE TABLE AS SELECT ... ?
> > >
> > > Good catch. I've attached an updated patch. I also included a few
> > > improvements to the docs.
> > >
> > > I think it would be a good idea to extend CREATE TABLE AS to allow WITH
> > > OIDS and WITHOUT OIDS to be specified, so that it provides a better
> > > option for people who need OIDs in their CREATE TABLE AS-generated
> > > tables than manually setting the default_use_oids GUC var (CREATE TABLE
> > > AS should also accept ON COMMIT ..., for that matter). But implementing
> > > this will require changing the internal representation of CREATE TABLE
> > > AS to be something more than just a wrapper over SelectStmt, I believe.
> > > I haven't made this change in the attached patch, but I'll probably do
> > > it before 7.5 is released. Any comments?
> > >
> > > -Neil
> > >
> >
> > [ Attachment, skipping... ]
> >
> > >
> > > ---------------------------(end of broadcast)---------------------------
> > > TIP 8: explain analyze is your friend
> >
> >
>
> --
> Peter Eisentraut   peter_e@gmx.net
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: Have you checked our extensive FAQ?
>
>                http://www.postgresql.org/docs/faqs/FAQ.html
>

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: export FUNC_MAX_ARGS as a read-only GUC variable
Next
From: Bruce Momjian
Date:
Subject: Re: ISO 8601 "Time Intervals" of the "format with time-unit