Re: bsd indent - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: bsd indent
Date
Msg-id 200310071547.h97FlJc13046@candle.pha.pa.us
Whole thread Raw
In response to bsd indent  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: bsd indent  (Andrew Dunstan <andrew@dunslane.net>)
Re: bsd indent  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
Andrew Dunstan wrote:
> 
> I grabbed the patched BSD indent from a mirror. Here's a couple of points:
> 
> . with a little trial and error GNU indent 2.2.9 actually did quite a 
> reasonable job for me last night. But I guess YMMV. I'm curious to know 
> what nasty mangling it does.

GNU indent does a reasonable job, but it did some strange spacing for
function definitions, if I remember correctly.  Can you test by running
pgindent and gnuindent through the /executor files and do a diff to see
the differences in formatting?

> . the file is a compressed tar file - it would be better to have a file 
> extension of .tgz or .tar.gz  instead of just .gz, so that this is apparent.

Done.  Sorry.

> . I had to hack the makefile for my linux box for a reasonably clean 
> build, so that the CFLAGS on the install line doesn't override setting 
> the defines, and the compiler won't complain about isblank and/or strdup 
> and/or fileno. The diff is attached for anyone interested.

OK, I updated it on the ftp site.  Can you download it?  It should have
size 41192.  Is _GNU_SOURCE required?  I didn't add that, but fixed the
install part.

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
359-1001+  If your life is a hard drive,     |  13 Roberts Road +  Christ can be your backup.        |  Newtown Square,
Pennsylvania19073
 


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Thoughts on maintaining 7.3
Next
From: Andrew Dunstan
Date:
Subject: Re: Thoughts on maintaining 7.3