Re: Stats Collector Error 7.4beta1 and 7.4beta2 - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: Stats Collector Error 7.4beta1 and 7.4beta2
Date
Msg-id 200309101548.h8AFmEb01718@candle.pha.pa.us
Whole thread Raw
In response to Re: Stats Collector Error 7.4beta1 and 7.4beta2  (Jan Wieck <JanWieck@Yahoo.com>)
List pgsql-hackers
Jan Wieck wrote:
> > For IPv6 you could do it with a memcmp on the sin6_addr part, and
> > put it inside an #ifdef HAVE_IPV6.
> > 
> > If you want to write code to compare 2 addresses, please make it
> > a general function and place it in ip.c.
> > 
> > Anyway, I'm happy with the current use of recv().
> 
> I disagree here. The clean and secure way is still to do *some* check 
> (because we carefully don't assume that all OS's behave like some 
> manpages happen to agree to). The performant way is to do it with 

If the OS behavior doesn't match the man page, can't we just call that
an OS bug?

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
359-1001+  If your life is a hard drive,     |  13 Roberts Road +  Christ can be your backup.        |  Newtown Square,
Pennsylvania19073
 


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Is it a memory leak in PostgreSQL 7.4beta?
Next
From: Tom Lane
Date:
Subject: Re: Is it a memory leak in PostgreSQL 7.4beta?