Re: new compile warning - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: new compile warning
Date
Msg-id 200308040254.h742sU423459@candle.pha.pa.us
Whole thread Raw
In response to Re: new compile warning  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane wrote:
> Joe Conway <mail@joeconway.com> writes:
> > plpython.c: In function `plpython_call_handler':
> > plpython.c:354: warning: suggest explicit braces to avoid ambiguous `else'
> 
> Apparently the Python boys are not familiar with the do {...} while (0)
> trick to ensure that a macro containing C statements won't interact with
> its environment.  I'll put back the braces that pgindent removed, but
> someone should file a bug report against Py_DECREF().
> 

Good fix.  That comment will prevent pgindent from modifying it in the
future.

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
359-1001+  If your life is a hard drive,     |  13 Roberts Road +  Christ can be your backup.        |  Newtown Square,
Pennsylvania19073
 


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: pgindent/copyright update done
Next
From: Joe Conway
Date:
Subject: statement level trigger causes pltcl, plpython SIGSEGV