Re: Patch to be verbose about being unable to read ~/.pgpasss... - Mailing list pgsql-patches

From Sean Chittenden
Subject Re: Patch to be verbose about being unable to read ~/.pgpasss...
Date
Msg-id 20030623071447.GV97131@perrin.int.nxad.com
Whole thread Raw
In response to Re: Patch to be verbose about being unable to read ~/.pgpasss...  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Patch to be verbose about being unable to read ~/.pgpasss...  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
> I could envision a helper procedure, known only within libpq, that has
> a signature like formatNotice(PGconn* conn, const char *fmtstring, ...)
> and encapsulates the work needed to handle a format string.  But I see
> no reason to push that work out to client applications.

I could make fnoticeProc private if you'd like, but that doesn't seem
smart if the user can override noticeFormat but can't with the
internal bits used by libpq... unless you're envisioning a private
method that constructs a msg for you, calls noticeProc with the buffer
as the arg, then then free()'s the result.

All regression tests pass with this case and no ABI or source
incompatabilities are introduced.

-sc

--
Sean Chittenden

Attachment

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: LIKE (second attempt)
Next
From: Tom Lane
Date:
Subject: Re: Small perf fixes/cleanup in src/backend/utils/adt/like.c...