Re: Adding Rendezvous support to postmaster - Mailing list pgsql-patches

Peter Eisentraut wrote:
> Bruce Momjian writes:
>
> > I will apply this patch soon, and add a configure test looking for:
> >
> >     #include <DNSServiceDiscovery/DNSServiceDiscovery.h>
> >
> > You reference that in your code, so it seems a logical way to set
> > HAVE_RENDEZVOUS.
>
> I think there should be a configure switch to turn it on or off.  Compare
> handling of readline.  Automatic discovery of optional features is evil.

Isn't "automatic discovery of optional features" what configure is all
about?  We have a readline flag only because we want to force people to
know when they don't have it.  I see this as similar to our move to make
syslog the default in all binaries that support it.  I thought we were
avoiding additional configure flags.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073