Re: Add CLUSTER ON to pg_dumps - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: Add CLUSTER ON to pg_dumps
Date
Msg-id 200303220346.h2M3kYP18922@candle.pha.pa.us
Whole thread Raw
In response to Re: Add CLUSTER ON to pg_dumps  (Alvaro Herrera <alvherre@dcc.uchile.cl>)
List pgsql-patches

I will make this adjustment to the patch.

---------------------------------------------------------------------------


Alvaro Herrera wrote:
> On Fri, Mar 21, 2003 at 12:25:17PM +0800, Christopher Kings-Lynne wrote:
>
> > +                 /*
> > +                  * If the index is clustered, we need to issue a CLUSTER command
> > +                  * since that is the only way of setting indisclustered.
> > +                  */
> > +                 if (indisclustered) {
> > +                     appendPQExpBuffer(q, "\nALTER TABLE %s CLUSTER",
> > +                                  fmtId(tbinfo->relname));
> > +                     appendPQExpBuffer(q, " ON %s;\n",
> > +                                  fmtId(indexrelname));
> > +                 }
>
> You forgot to update the comments...
>
> --
> Alvaro Herrera (<alvherre[a]dcc.uchile.cl>)
> "Escucha y olvidar?s; ve y recordar?s; haz y entender?s" (Confucio)
>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: if posting/reading through Usenet, please send an appropriate
> subscribe-nomail command to majordomo@postgresql.org so that your
> message can get through to the mailing list cleanly
>

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073


pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Add CLUSTER ON to pg_dumps
Next
From: Ian Barwick
Date:
Subject: psql / tab-completion.c : patch proposals