Re: psql patch (2) - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: psql patch (2)
Date
Msg-id 200303201545.h2KFjGJ28121@candle.pha.pa.us
Whole thread Raw
In response to psql patch (2)  ("Jeroen T. Vermeulen" <jtv@xs4all.nl>)
List pgsql-patches
OK, fixed as you suggested.

---------------------------------------------------------------------------

Jeroen T. Vermeulen wrote:
> On Thu, Mar 20, 2003 at 01:45:31AM -0500, Bruce Momjian wrote:
> >
> > I also adjusted this:
> >
> >     + char parse_char(char **buf)
> >     + {
> >     +   long l;
> >     +
> >     +   l = strtol(*buf, buf, 0);
> >     +   (*buf)--;
> >     +   return (char)l;
> >     + }
> >     +
> >
> > I added the parens around 'buf' because the compiler was saying
> > statement has no effect.  Is this correct?
>
> I don't remember what this function does, but you could also write
> '--*buf;' to save on parentheses (and do your bit for the environment).
>
>
> Jeroen
>
>

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

pgsql-patches by date:

Previous
From: Karel Zak
Date:
Subject: Re: to_char PL/MI fix
Next
From: Bruce Momjian
Date:
Subject: Re: to_char PL/MI fix