Re: psql and readline - Mailing list pgsql-hackers

From Ross J. Reedstrom
Subject Re: psql and readline
Date
Msg-id 20030218235545.GA14708@wallace.ece.rice.edu
Whole thread Raw
In response to Re: psql and readline  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-hackers
On Wed, Feb 19, 2003 at 12:03:44AM +0100, Peter Eisentraut wrote:
> Ross J. Reedstrom writes:
> 
> > Yes, BSD systems that install libedit directly in /usr/include (or into
> > readline), like Patrick's,  don't need it, but mine do. Is there some
> > reason we _shouldn't_ support this configuration?
> 
> I don't like adding code to support every configuration that someone
> dreamed up but no one actually needs.  Readline installs the header files
> into <readline/readline.h> and if someone thinks they can change that they
> deserve to pay the price.  The configure script is already slow enough
> without this.

Hmm, isn't this exactly what configure is  for? To find out where this
particular system installs all the bits and pieces? Note that even without
the test for editline/readline.h, the existing configure looks in two
placesi for readline functionality, so doesn't match your comment,
above. As for 'someone changing that' paying the price, I think it's
reasonable for an incomplete compatability library to install into a
different location: if it claims to be readline/readline.h, it better
support the entire API, in my book.

Regardless of all of the above, I'm willing to let this part go. Note that
I can no longer easily test libedit functionality in that case, however.
I leave it up to Bruce (or whomever applies the patch)

Ross


pgsql-hackers by date:

Previous
From: Patrick Welche
Date:
Subject: Re: request for sql3 compliance for the update command
Next
From: Vincent van Leeuwen
Date:
Subject: Re: Hard problem with concurrency