Tatsuo Ishii wrote:
> > Tatsuo Ishii <t-ishii@sra.co.jp> writes:
> > > + /* Flag to we need to initialize client encoding info */
> > > + static bool need_to_init_client_encoding = -1;
> >
> > Surely that should be int, not bool.
>
> Oops. Will fix.
>
> > > ! if (!PQsendQuery(conn, "begin; select pg_client_encoding(); commit"))
> >
> > Doesn't this break compatibility with pre-7.2 databases? AFAICT that
> > function was introduced in 7.2.
>
> Yes, but there seems no other way to solve the problem and I thought we
> do not guarantee the compatibilty between 7.3 frontend and pre 7.3 servers.
Yep. Tatsuo, you should apply the patch to fix the problem. Shame this
didn't make it into 7.3.2. Should we backpatch?
-- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610)
359-1001+ If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square,
Pennsylvania19073
