Re: pgsql-server/ oc/src/sgml/reference.sgml oc/sr ... - Mailing list pgsql-committers

From Bruce Momjian
Subject Re: pgsql-server/ oc/src/sgml/reference.sgml oc/sr ...
Date
Msg-id 200212062141.gB6LfjP18810@candle.pha.pa.us
Whole thread Raw
In response to pgsql-server/ oc/src/sgml/reference.sgml oc/sr ...  (momjian@postgresql.org (Bruce Momjian - CVS))
List pgsql-committers
I am testing a new method for applying patches. Basically, I have test
script that does:

    . /etc/profile
    pgstop
    rm -r /u/pg/data
    pgmakeall -c &&
    aspg initdb &&
    pgstart &&
    newdb test &&
    cd /pg/test/regress &&
    gmake clean &&
    aspg gmake all runtest
    newdb test

Unfortunately, it takes quite a while to run, so I typically run it only
after I have applied a batch of patches, and usually I can clean up a
compiler warning or regression omission.  These patches were different,
and I am still trying to figure out when to run the full test script.

As it is, I have spent all day testing the IPv6 patch, and just compiled
a debug version of libc to continue testing, and I am not even done.  I
wanted to do advocacy stuff today too.  :-(

---------------------------------------------------------------------------

> Tom Lane wrote:
> > momjian@postgresql.org (Bruce Momjian - CVS) writes:
> > >     Back out ALTER DOMAIN patch until missing file appears.
> >
> > not to mention
> >
> > >    Back out V6 code, caused postmaster startup failure.
> >
> >
> > Bruce, I know I've said this before, but I'm going to complain again:
> > please test patches, particularly large ones, BEFORE you commit 'em,
> > not after.  This sort of CVS thrashing gets in the way of other
> > developers, who have to contend with unnecessary merge work.
> > It's not helping Marc's disk-space and bandwidth budgets, either.
> >
> >             regards, tom lane
> >
>
> --
>   Bruce Momjian                        |  http://candle.pha.pa.us
>   pgman@candle.pha.pa.us               |  (610) 359-1001
>   +  If your life is a hard drive,     |  13 Roberts Road
>   +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

pgsql-committers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: pgsql-server/ oc/src/sgml/reference.sgml oc/sr ...
Next
From: "Centro Relax"
Date:
Subject: Fuera estrés ya !!!