Re: Win32 port - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: Win32 port
Date
Msg-id 200211061920.gA6JKSr19217@candle.pha.pa.us
Whole thread Raw
In response to Re: Win32 port  (Jan Wieck <JanWieck@Yahoo.com>)
List pgsql-hackers
Jan Wieck wrote:
> Bruce Momjian wrote:
> > 
> > Peter Eisentraut wrote:
> > > Jan Wieck writes:
> > >
> > > > To Hannu: the Windows port we did here depends on MS VC++ features like
> > > > the ability to specify in the project to substitute header files. I
> > > > don't know much about MingW and if you can do things like that with it.
> > >
> > > Before long someone will port the Windows port to MinGW, so we should
> > > resist attempts to use compiler-specific features in the same way that we
> > > tend not to use vendors specific features in other ports.
> > 
> > Agreed.  I will make as clean a patch as possible.  I think it is
> > doable.
> 
> The thing with this particular feature was not to touch almost every
> source file in the whole tree. The headers to #include in a clean Win32
> world are totally different from what you #include in Unix.

OK, I am looking at the SRA patch and I don't see a huge number of
#include changes.  Can you give an example?  Also, isn't there a way to
do this in a more centralized way, perhaps in c.h?

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
359-1001+  If your life is a hard drive,     |  13 Roberts Road +  Christ can be your backup.        |  Newtown Square,
Pennsylvania19073
 


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Win32 port
Next
From: "scott.marlowe"
Date:
Subject: Re: Stability problems