Re: move 0 behaviour - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: move 0 behaviour
Date
Msg-id 200211020314.gA23EuN07245@candle.pha.pa.us
Whole thread Raw
In response to Re: move 0 behaviour  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: move 0 behaviour  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > The following patch makes FETCH/MOVE 0 do nothing, and FETCH LAST move
> > to the end.
> 
> Do not hack up PerformPortalFetch; put the special case for INT_MAX in
> utility.c's FetchStmt code, instead.  As-is, you probably broke other
> callers of PerformPortalFetch.

I thought about that, but I need to fail if the cursor name is invalid. 
Those tests are done in PerformPortalFetch().  The good news is that no
one else call it.  Other ideas?
> BTW, there's a comment in parsenodes.h that needs to be fixed too:
> 
>     int            howMany;        /* amount to fetch ("ALL" --> 0) */

Done.

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
359-1001+  If your life is a hard drive,     |  13 Roberts Road +  Christ can be your backup.        |  Newtown Square,
Pennsylvania19073
 


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [GENERAL] What user to defaults execute as?
Next
From: Bruce Momjian
Date:
Subject: Re: elog(PANIC) should abort()?