Re: pg_dump and large files - is this a problem? - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: pg_dump and large files - is this a problem?
Date
Msg-id 200210221916.g9MJGIn20751@candle.pha.pa.us
Whole thread Raw
In response to Re: pg_dump and large files - is this a problem?  (Philip Warner <pjw@rhyme.com.au>)
List pgsql-hackers
Patch applied with shift <</>> changes by me.  Thanks.

---------------------------------------------------------------------------


Philip Warner wrote:
> 
> I have put the latest patch at:
> 
>      http://downloads.rhyme.com.au/postgresql/pg_dump/
> 
> along with two dump files of the regression DB, one with 4 byte
> and the other with 8 byte offsets. I can read/restore each from
> the other, so it looks pretty good. Once the endianness is tested,
> we should be OK.
> 
> Known problems:
> 
> - will not cope with > 4GB files and size_t not 64 bit.
> - when printing data position, it is assumed that off_t is UINT64
>    (we could remove this entirely - it's just for display)
> - if seek is not supported, then an intXX is assigned to off_t
>    when file offsets are needed. This *should* not cause a problem
>    since without seek, the offsets will not be written to the file.
> 
> Changes from Prior Version:
> 
> - No longer stores or outputs data length
> - Assumes result of ftello is correct if it disagrees with internally
>    kept tally.
> - 'pg_restore -l' now shows sizes of int and offset.
> 
> 
> ----------------------------------------------------------------
> Philip Warner                    |     __---_____
> Albatross Consulting Pty. Ltd.   |----/       -  \
> (A.B.N. 75 008 659 498)          |          /(@)   ______---_
> Tel: (+61) 0500 83 82 81         |                 _________  \
> Fax: (+61) 0500 83 82 82         |                 ___________ |
> Http://www.rhyme.com.au          |                /           \|
>                                   |    --________--
> PGP key available upon request,  |  /
> and from pgp5.ai.mit.edu:11371   |/
> 
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 4: Don't 'kill -9' the postmaster
> 

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
359-1001+  If your life is a hard drive,     |  13 Roberts Road +  Christ can be your backup.        |  Newtown Square,
Pennsylvania19073
 


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pg_dump and large files - is this a problem?
Next
From: Peter Eisentraut
Date:
Subject: Re: CVS split problems