Re: Some changes related to NAMEDATALEN 32->64 - Mailing list pgsql-patches

Patch applied.  Thanks.

---------------------------------------------------------------------------


Kris Jurka wrote:
>
> Changes to documentation and the regression tests for the default
> NAMEDATALEN of 64.
>
> Kris Jurka

> Index: doc/FAQ_DEV
> ===================================================================
> RCS file: /projects/cvsroot/pgsql-server/doc/FAQ_DEV,v
> retrieving revision 1.45
> diff -c -r1.45 FAQ_DEV
> *** doc/FAQ_DEV    2002/08/13 20:41:13    1.45
> --- doc/FAQ_DEV    2002/09/07 18:31:41
> ***************
> *** 560,566 ****
>      Table, column, type, function, and view names are stored in system
>      tables in columns of type Name. Name is a fixed-length,
>      null-terminated type of NAMEDATALEN bytes. (The default value for
> !    NAMEDATALEN is 32 bytes.)
>   typedef struct nameData
>       {
>           char        data[NAMEDATALEN];
> --- 560,566 ----
>      Table, column, type, function, and view names are stored in system
>      tables in columns of type Name. Name is a fixed-length,
>      null-terminated type of NAMEDATALEN bytes. (The default value for
> !    NAMEDATALEN is 64 bytes.)
>   typedef struct nameData
>       {
>           char        data[NAMEDATALEN];
> Index: doc/src/FAQ/FAQ_DEV.html
> ===================================================================
> RCS file: /projects/cvsroot/pgsql-server/doc/src/FAQ/FAQ_DEV.html,v
> retrieving revision 1.48
> diff -c -r1.48 FAQ_DEV.html
> *** doc/src/FAQ/FAQ_DEV.html    2002/08/13 20:41:13    1.48
> --- doc/src/FAQ/FAQ_DEV.html    2002/09/07 18:31:51
> ***************
> *** 671,677 ****
>       <P>Table, column, type, function, and view names are stored in
>       system tables in columns of type <I>Name.</I> Name is a
>       fixed-length, null-terminated type of <I>NAMEDATALEN</I> bytes.
> !     (The default value for NAMEDATALEN is 32 bytes.)</P>
>   <PRE>
>   <CODE>typedef struct nameData
>       {
> --- 671,677 ----
>       <P>Table, column, type, function, and view names are stored in
>       system tables in columns of type <I>Name.</I> Name is a
>       fixed-length, null-terminated type of <I>NAMEDATALEN</I> bytes.
> !     (The default value for NAMEDATALEN is 64 bytes.)</P>
>   <PRE>
>   <CODE>typedef struct nameData
>       {
> Index: src/test/regress/expected/name.out
> ===================================================================
> RCS file: /projects/cvsroot/pgsql-server/src/test/regress/expected/name.out,v
> retrieving revision 1.6
> diff -c -r1.6 name.out
> *** src/test/regress/expected/name.out    2002/08/13 20:40:44    1.6
> --- src/test/regress/expected/name.out    2002/09/07 18:31:58
> ***************
> *** 1,6 ****
>   --
>   -- NAME
> ! -- all inputs are silently truncated at NAMEDATALEN (32) characters
>   --
>   -- fixed-length by reference
>   SELECT name 'name string' = name 'name string' AS "True";
> --- 1,6 ----
>   --
>   -- NAME
> ! -- all inputs are silently truncated at NAMEDATALEN-1 (63) characters
>   --
>   -- fixed-length by reference
>   SELECT name 'name string' = name 'name string' AS "True";
> Index: src/test/regress/sql/name.sql
> ===================================================================
> RCS file: /projects/cvsroot/pgsql-server/src/test/regress/sql/name.sql,v
> retrieving revision 1.6
> diff -c -r1.6 name.sql
> *** src/test/regress/sql/name.sql    2002/08/13 20:40:44    1.6
> --- src/test/regress/sql/name.sql    2002/09/07 18:31:59
> ***************
> *** 1,6 ****
>   --
>   -- NAME
> ! -- all inputs are silently truncated at NAMEDATALEN (32) characters
>   --
>
>   -- fixed-length by reference
> --- 1,6 ----
>   --
>   -- NAME
> ! -- all inputs are silently truncated at NAMEDATALEN-1 (63) characters
>   --
>
>   -- fixed-length by reference

>
> ---------------------------(end of broadcast)---------------------------
> TIP 4: Don't 'kill -9' the postmaster

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073