Re: I am done - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: I am done
Date
Msg-id 200209051530.g85FU8v07822@candle.pha.pa.us
Whole thread Raw
In response to Re: I am done  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: I am done
List pgsql-hackers
Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> >> I do not see a good reason why "fatal" and "off" shouldn't be allowed
> >> values for all three message variables.  If we just did that, then you'd
> >> be back to sharable code.
> 
> > I recommended he only allow valid values for each variable.  I think if
> > we say we only support values X,Y,Z we had better throw an error if it
> > anything else.
> 
> That's not what I said: I said allow all the values for each variable.
> And document it.  Why shouldn't we let people turn off error logging
> if they want to?

But the client side doesn't make any sense to support FATAL.  Am I
missing something?

> > Seems a new GUC variable seems like overkill to me, and I think we need
> > to allow it to be raised. I think we can make server_min_messages
> > PGC_SUSET so only the admin can change it.
> 
> Okay, and log_min_error_statement too.

Yes.

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
359-1001+  If your life is a hard drive,     |  13 Roberts Road +  Christ can be your backup.        |  Newtown Square,
Pennsylvania19073
 


pgsql-hackers by date:

Previous
From: "Dave Page"
Date:
Subject: Re: [CYGWIN] 7.3 Beta 1 Build Error on Cygwin
Next
From: Tom Lane
Date:
Subject: Re: I am done