Re: contrib/ intarray, ltree, intagg broken(?) by array changes - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: contrib/ intarray, ltree, intagg broken(?) by array changes
Date
Msg-id 200209021337.g82DbQS25741@candle.pha.pa.us
Whole thread Raw
In response to Re: contrib/ intarray, ltree, intagg broken(?) by array  (Oleg Bartunov <oleg@sai.msu.su>)
List pgsql-hackers
I have already received a patch that modifies the regression tests and
it seems things are working.  However, it would be good for you to take
a look.  Fortunately, that can be done anytime during beta. Thanks.

---------------------------------------------------------------------------

Oleg Bartunov wrote:
> We'll be back to work next week and look into code.
> 
>     Oleg
> On Sun, 1 Sep 2002, Bruce Momjian wrote:
> 
> >
> > Can someone address the intagg issue here, or is the code OK?
> >
> > ---------------------------------------------------------------------------
> >
> > Tom Lane wrote:
> > > Joe Conway and I have just committed some changes in the internal
> > > representation of Postgres arrays: an element-type-OID field is added to
> > > the array header, and alignment calculations are now done the same way
> > > as in ordinary tuple storage, instead of taking shortcuts.  I believe
> > > that these changes need to be reflected into the intarray, ltree, and
> > > intagg contrib modules.
> > >
> > > intarray and ltree both seem to be mapping their own declarations onto
> > > arrays using largely-similar code.  But while intarray fails its
> > > regression test, I find ltree still passes.  So I'm confused about what
> > > that code is really doing and don't want to touch it.
> > >
> > > I tried to fix intagg, but since there is no regression test for it
> > > I'm unsure whether it's okay.
> > >
> > > Could you folks take a look at CVS tip and see what changes are needed,
> > > if any?
> > >
> > > In the longer run, it might be possible to improve these routines to be
> > > array-type-polymorphic using the new features.  But with the 7.3 beta
> > > date nearly upon us, I'd counsel first making the existing functionality
> > > work again...
> > >
> > >             regards, tom lane
> > >
> > > ---------------------------(end of broadcast)---------------------------
> > > TIP 3: if posting/reading through Usenet, please send an appropriate
> > > subscribe-nomail command to majordomo@postgresql.org so that your
> > > message can get through to the mailing list cleanly
> > >
> >
> >
> 
>     Regards,
>         Oleg
> _____________________________________________________________
> Oleg Bartunov, sci.researcher, hostmaster of AstroNet,
> Sternberg Astronomical Institute, Moscow University (Russia)
> Internet: oleg@sai.msu.su, http://www.sai.msu.su/~megera/
> phone: +007(095)939-16-83, +007(095)939-23-83
> 
> 

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
359-1001+  If your life is a hard drive,     |  13 Roberts Road +  Christ can be your backup.        |  Newtown Square,
Pennsylvania19073
 


pgsql-hackers by date:

Previous
From: Tatsuo Ishii
Date:
Subject: Re: [7.3-devl] converision test fails
Next
From: Bruce Momjian
Date:
Subject: Re: current build fail