Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > else if (*s == 0)
> > ! elog(ERROR, "pg_atoi: zero-length string!");
>
> The exclamation point seems inappropriate. Perhaps "zero-length input"
> would be better than "string" also.
I copied the other test case:
if (s == (char *) NULL) elog(ERROR, "pg_atoi: NULL pointer!");
I removed them both '!'.
> Otherwise this seems like a reasonable thing to do.
OK, will apply now.
-- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610)
359-1001+ If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square,
Pennsylvania19073
