Re: utils C files - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: utils C files
Date
Msg-id 200207180435.g6I4ZQw07535@candle.pha.pa.us
Whole thread Raw
In response to Re: utils C files  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: utils C files  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > How is this any better than just mentioning the *.o file and letting the
> > default rules compile it.  I don't understand how linking to the current
> > directory gets us anything.  Now, if you did a 'make -C dir target' that
> > would be different.
>
> The whole point of the pushups for libpq is that we DON'T want the
> default rules.  We need to compile it PIC so that it can go into a
> shared library.  This will not be the same object file built in the
> ports directory.

OK, I have moved the files to src/port.  Would people like this rule
added to Makefile.global.in so that any usage of src/port/*.c files will
compile in the local directory?

    ifdef SNPRINTF
    $(basename $(notdir $(SNPRINTF))).c: $(basename $(SNPRINTF)).c
            rm -f $@ && $(LN_S) $< .
    endif

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: utils C files
Next
From: Bruce Momjian
Date:
Subject: Re: Table Function API patch (was Re: another SRF question)