Re: BETWEEN Node & DROP COLUMN - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: BETWEEN Node & DROP COLUMN
Date
Msg-id 200207040218.g642IS010518@candle.pha.pa.us
Whole thread Raw
In response to BETWEEN Node & DROP COLUMN  ("Christopher Kings-Lynne" <chriskl@familyhealth.com.au>)
Responses Re: BETWEEN Node & DROP COLUMN  ("Christopher Kings-Lynne" <chriskl@familyhealth.com.au>)
List pgsql-hackers
Christopher Kings-Lynne wrote:
> > > > > Yes, please remind me.  Was your solution renumbering the
> > attno values?
> > > >
> > > > Yes though I don't intend to object to Christopher's proposal.
> 
> Hiroshi,
> 
> I am thinking of rolling back my CVS to see if there's code from your
> previous test implementation that we can use.  Apart from the DropColumn
> function itself, what other changes did you make?  Did you have
> modifications for '*' expansion in the parser, etc.?

Yes, please review Hiroshi's work.  It is good work.  Can we have an
analysis of Hiroshi's approach vs the isdropped case.

Is it better to renumber the attno or set a column to isdropped.  The
former may be easier on the clients.

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026
 




pgsql-hackers by date:

Previous
From: Hiroshi Inoue
Date:
Subject: Re: BETWEEN Node & DROP COLUMN
Next
From: "Christopher Kings-Lynne"
Date:
Subject: Re: BETWEEN Node & DROP COLUMN