Re: Make factorial(0::int2) return 1, as per spec. - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: Make factorial(0::int2) return 1, as per spec.
Date
Msg-id 200206072343.g57NhOv07278@candle.pha.pa.us
Whole thread Raw
In response to Re: Make factorial(0::int2) return 1, as per spec.  (Florian Weimer <Weimer@CERT.Uni-Stuttgart.DE>)
List pgsql-patches
Change made for int2 and int4.

---------------------------------------------------------------------------

Florian Weimer wrote:
> sugita@sra.co.jp writes:
>
> > -    if (arg1 < 1)
> > +    if (arg1 == 0)
> > +        result = 1;
> > +    else if (arg1 < 1)
> >          result = 0;
> >      else
> >          for (result = 1; arg1 > 0; --arg1)
>
> The second "if" should compare with 0, not 1.  (It doesn't make a
> difference, it's only about readability.)
>
> --
> Florian Weimer                       Weimer@CERT.Uni-Stuttgart.DE
> University of Stuttgart           http://CERT.Uni-Stuttgart.DE/people/fw/
> RUS-CERT                          +49-711-685-5973/fax +49-711-685-5898
>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: Have you checked our extensive FAQ?
>
> http://www.postgresql.org/users-lounge/docs/faq.html
>

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Make factorial(0::int2) return 1, as per spec.
Next
From: Bruce Momjian
Date:
Subject: Re: JDBC CStmt (inline this time)