Re: ALT*R T*BL* S*T / DR*P N*T N*LL patch - 4th try - Mailing list pgsql-patches

From Christopher Kings-Lynne
Subject Re: ALT*R T*BL* S*T / DR*P N*T N*LL patch - 4th try
Date
Msg-id 20020331133339.R82404-100000@houston.familyhealth.com.au
Whole thread Raw
In response to Re: ALT*R T*BL* S*T / DR*P N*T N*LL patch - 4th try  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
> This looks good but I'm afraid it's out of step with recent changes
> for schema support.  In particular, heap_openr is now The Wrong Thing
> to use for anything except access to system relations.  As of CVS tip,
> all the AlterTable routines use OID parameters not name parameters
> to identify the table to work on.  Could I ask you to update the patch
> to match the coding style in CVS tip?

Yep - already done - I was just about to resubmit it.

> > The only thing I haven't checked are my ecpg changes.  I would like someone
> > with more ecpg experience to check my preproc.y changes.
>
> I'd suggest leaving ecpg to Michael; he seems to prefer to do those
> updates himself.

Hmmm...I'll just leave it out then i guess...

Regards,

Chris



pgsql-patches by date:

Previous
From: "Rod Taylor"
Date:
Subject: Re: Insert ... (a, b, DEFAULT, c, d);
Next
From: Christopher Kings-Lynne
Date:
Subject: Nullability patch take 2