ODBC warnings - Mailing list pgsql-patches

I am seeing the following compile warnings in the ODBC code.  This is
with the following in Makefile.custom:

  CUSTOM_COPT=-g -O0 -Wall -Wmissing-prototypes -Wmissing-declarations -Wpointer-arith -Wcast-align

Can someone fix it?

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
gcc -O2 -pipe -m486 -Wall -Wmissing-prototypes -Wmissing-declarations -g -O0 -Wall -Wmissing-prototypes
-Wmissing-declarations-Wpointer-arith -Wcast-align -fpic -I. -I../../../src/include -I/usr/local/include/readline
-I/usr/contrib/include-DFRONTEND -DMD5_ODBC -DODBCINSTDIR='"/usr/local/pgsql/etc"'  -c -o info.o info.c 
info.c: In function `PGAPI_TablePrivileges':
info.c:3986: warning: suggest parentheses around assignment used as truth value
gcc -O2 -pipe -m486 -Wall -Wmissing-prototypes -Wmissing-declarations -g -O0 -Wall -Wmissing-prototypes
-Wmissing-declarations-Wpointer-arith -Wcast-align -fpic -I. -I../../../src/include -I/usr/local/include/readline
-I/usr/contrib/include-DFRONTEND -DMD5_ODBC -DODBCINSTDIR='"/usr/local/pgsql/etc"'  -c -o bind.o bind.c 
bind.c: In function `PGAPI_ParamOptions':
bind.c:343: warning: assignment from incompatible pointer type
gcc -O2 -pipe -m486 -Wall -Wmissing-prototypes -Wmissing-declarations -g -O0 -Wall -Wmissing-prototypes
-Wmissing-declarations-Wpointer-arith -Wcast-align -fpic -I. -I../../../src/include -I/usr/local/include/readline
-I/usr/contrib/include-DFRONTEND -DMD5_ODBC -DODBCINSTDIR='"/usr/local/pgsql/etc"'  -c -o columninfo.o columninfo.c 
gcc -O2 -pipe -m486 -Wall -Wmissing-prototypes -Wmissing-declarations -g -O0 -Wall -Wmissing-prototypes
-Wmissing-declarations-Wpointer-arith -Wcast-align -fpic -I. -I../../../src/include -I/usr/local/include/readline
-I/usr/contrib/include-DFRONTEND -DMD5_ODBC -DODBCINSTDIR='"/usr/local/pgsql/etc"'  -c -o connection.o connection.c 
connection.c: In function `CC_send_query':
connection.c:1133: warning: unused variable `result_in'
gcc -O2 -pipe -m486 -Wall -Wmissing-prototypes -Wmissing-declarations -g -O0 -Wall -Wmissing-prototypes
-Wmissing-declarations-Wpointer-arith -Wcast-align -fpic -I. -I../../../src/include -I/usr/local/include/readline
-I/usr/contrib/include-DFRONTEND -DMD5_ODBC -DODBCINSTDIR='"/usr/local/pgsql/etc"'  -c -o convert.o convert.c 
convert.c: In function `timestamp2stime':
convert.c:164: warning: unused variable `timediff'
convert.c: In function `copy_statement_with_parameters':
convert.c:1467: warning: passing arg 5 of `convert_escape' from incompatible pointer type
gcc -O2 -pipe -m486 -Wall -Wmissing-prototypes -Wmissing-declarations -g -O0 -Wall -Wmissing-prototypes
-Wmissing-declarations-Wpointer-arith -Wcast-align -fpic -I. -I../../../src/include -I/usr/local/include/readline
-I/usr/contrib/include-DFRONTEND -DMD5_ODBC -DODBCINSTDIR='"/usr/local/pgsql/etc"'  -c -o drvconn.o drvconn.c 
gcc -O2 -pipe -m486 -Wall -Wmissing-prototypes -Wmissing-declarations -g -O0 -Wall -Wmissing-prototypes
-Wmissing-declarations-Wpointer-arith -Wcast-align -fpic -I. -I../../../src/include -I/usr/local/include/readline
-I/usr/contrib/include-DFRONTEND -DMD5_ODBC -DODBCINSTDIR='"/usr/local/pgsql/etc"'  -c -o environ.o environ.c 
environ.c: In function `PGAPI_StmtError':
environ.c:98: warning: suggest parentheses around comparison in operand of &
environ.c:99: warning: suggest parentheses around comparison in operand of &
environ.c:97: warning: unused variable `once_again'
gcc -O2 -pipe -m486 -Wall -Wmissing-prototypes -Wmissing-declarations -g -O0 -Wall -Wmissing-prototypes
-Wmissing-declarations-Wpointer-arith -Wcast-align -fpic -I. -I../../../src/include -I/usr/local/include/readline
-I/usr/contrib/include-DFRONTEND -DMD5_ODBC -DODBCINSTDIR='"/usr/local/pgsql/etc"'  -c -o execute.o execute.c 
gcc -O2 -pipe -m486 -Wall -Wmissing-prototypes -Wmissing-declarations -g -O0 -Wall -Wmissing-prototypes
-Wmissing-declarations-Wpointer-arith -Wcast-align -fpic -I. -I../../../src/include -I/usr/local/include/readline
-I/usr/contrib/include-DFRONTEND -DMD5_ODBC -DODBCINSTDIR='"/usr/local/pgsql/etc"'  -c -o lobj.o lobj.c 
gcc -O2 -pipe -m486 -Wall -Wmissing-prototypes -Wmissing-declarations -g -O0 -Wall -Wmissing-prototypes
-Wmissing-declarations-Wpointer-arith -Wcast-align -fpic -I. -I../../../src/include -I/usr/local/include/readline
-I/usr/contrib/include-DFRONTEND -DMD5_ODBC -DODBCINSTDIR='"/usr/local/pgsql/etc"'  -c -o md5.o md5.c 
gcc -O2 -pipe -m486 -Wall -Wmissing-prototypes -Wmissing-declarations -g -O0 -Wall -Wmissing-prototypes
-Wmissing-declarations-Wpointer-arith -Wcast-align -fpic -I. -I../../../src/include -I/usr/local/include/readline
-I/usr/contrib/include-DFRONTEND -DMD5_ODBC -DODBCINSTDIR='"/usr/local/pgsql/etc"'  -c -o misc.o misc.c 
gcc -O2 -pipe -m486 -Wall -Wmissing-prototypes -Wmissing-declarations -g -O0 -Wall -Wmissing-prototypes
-Wmissing-declarations-Wpointer-arith -Wcast-align -fpic -I. -I../../../src/include -I/usr/local/include/readline
-I/usr/contrib/include-DFRONTEND -DMD5_ODBC -DODBCINSTDIR='"/usr/local/pgsql/etc"'  -c -o options.o options.c 
gcc -O2 -pipe -m486 -Wall -Wmissing-prototypes -Wmissing-declarations -g -O0 -Wall -Wmissing-prototypes
-Wmissing-declarations-Wpointer-arith -Wcast-align -fpic -I. -I../../../src/include -I/usr/local/include/readline
-I/usr/contrib/include-DFRONTEND -DMD5_ODBC -DODBCINSTDIR='"/usr/local/pgsql/etc"'  -c -o pgtypes.o pgtypes.c 
pgtypes.c: In function `pgtype_to_sqltype':
pgtypes.c:237: warning: unused variable `env'
pgtypes.c: In function `pgtype_to_ctype':
pgtypes.c:345: warning: unused variable `env'
gcc -O2 -pipe -m486 -Wall -Wmissing-prototypes -Wmissing-declarations -g -O0 -Wall -Wmissing-prototypes
-Wmissing-declarations-Wpointer-arith -Wcast-align -fpic -I. -I../../../src/include -I/usr/local/include/readline
-I/usr/contrib/include-DFRONTEND -DMD5_ODBC -DODBCINSTDIR='"/usr/local/pgsql/etc"'  -c -o psqlodbc.o psqlodbc.c 
gcc -O2 -pipe -m486 -Wall -Wmissing-prototypes -Wmissing-declarations -g -O0 -Wall -Wmissing-prototypes
-Wmissing-declarations-Wpointer-arith -Wcast-align -fpic -I. -I../../../src/include -I/usr/local/include/readline
-I/usr/contrib/include-DFRONTEND -DMD5_ODBC -DODBCINSTDIR='"/usr/local/pgsql/etc"'  -c -o qresult.o qresult.c 
qresult.c: In function `QR_read_tuple':
qresult.c:735: warning: unsigned int format, UDWORD arg (arg 3)
qresult.c:738: warning: unsigned int format, UDWORD arg (arg 3)
gcc -O2 -pipe -m486 -Wall -Wmissing-prototypes -Wmissing-declarations -g -O0 -Wall -Wmissing-prototypes
-Wmissing-declarations-Wpointer-arith -Wcast-align -fpic -I. -I../../../src/include -I/usr/local/include/readline
-I/usr/contrib/include-DFRONTEND -DMD5_ODBC -DODBCINSTDIR='"/usr/local/pgsql/etc"'  -c -o results.o results.c 
gcc -O2 -pipe -m486 -Wall -Wmissing-prototypes -Wmissing-declarations -g -O0 -Wall -Wmissing-prototypes
-Wmissing-declarations-Wpointer-arith -Wcast-align -fpic -I. -I../../../src/include -I/usr/local/include/readline
-I/usr/contrib/include-DFRONTEND -DMD5_ODBC -DODBCINSTDIR='"/usr/local/pgsql/etc"'  -c -o socket.o socket.c 
gcc -O2 -pipe -m486 -Wall -Wmissing-prototypes -Wmissing-declarations -g -O0 -Wall -Wmissing-prototypes
-Wmissing-declarations-Wpointer-arith -Wcast-align -fpic -I. -I../../../src/include -I/usr/local/include/readline
-I/usr/contrib/include-DFRONTEND -DMD5_ODBC -DODBCINSTDIR='"/usr/local/pgsql/etc"'  -c -o parse.o parse.c 
gcc -O2 -pipe -m486 -Wall -Wmissing-prototypes -Wmissing-declarations -g -O0 -Wall -Wmissing-prototypes
-Wmissing-declarations-Wpointer-arith -Wcast-align -fpic -I. -I../../../src/include -I/usr/local/include/readline
-I/usr/contrib/include-DFRONTEND -DMD5_ODBC -DODBCINSTDIR='"/usr/local/pgsql/etc"'  -c -o statement.o statement.c 
gcc -O2 -pipe -m486 -Wall -Wmissing-prototypes -Wmissing-declarations -g -O0 -Wall -Wmissing-prototypes
-Wmissing-declarations-Wpointer-arith -Wcast-align -fpic -I. -I../../../src/include -I/usr/local/include/readline
-I/usr/contrib/include-DFRONTEND -DMD5_ODBC -DODBCINSTDIR='"/usr/local/pgsql/etc"'  -c -o tuple.o tuple.c 
gcc -O2 -pipe -m486 -Wall -Wmissing-prototypes -Wmissing-declarations -g -O0 -Wall -Wmissing-prototypes
-Wmissing-declarations-Wpointer-arith -Wcast-align -fpic -I. -I../../../src/include -I/usr/local/include/readline
-I/usr/contrib/include-DFRONTEND -DMD5_ODBC -DODBCINSTDIR='"/usr/local/pgsql/etc"'  -c -o tuplelist.o tuplelist.c 
gcc -O2 -pipe -m486 -Wall -Wmissing-prototypes -Wmissing-declarations -g -O0 -Wall -Wmissing-prototypes
-Wmissing-declarations-Wpointer-arith -Wcast-align -fpic -I. -I../../../src/include -I/usr/local/include/readline
-I/usr/contrib/include-DFRONTEND -DMD5_ODBC -DODBCINSTDIR='"/usr/local/pgsql/etc"'  -c -o dlg_specific.o dlg_specific.c 
dlg_specific.c: In function `makeConnectString':
dlg_specific.c:652: warning: unsigned int format, long unsigned int arg (arg 10)
dlg_specific.c: In function `unfoldCXAttribute':
dlg_specific.c:665: warning: unsigned int format, long unsigned int arg (arg 3)
dlg_specific.c:673: warning: unsigned int format, long unsigned int arg (arg 3)
gcc -O2 -pipe -m486 -Wall -Wmissing-prototypes -Wmissing-declarations -g -O0 -Wall -Wmissing-prototypes
-Wmissing-declarations-Wpointer-arith -Wcast-align -fpic -I. -I../../../src/include -I/usr/local/include/readline
-I/usr/contrib/include-DFRONTEND -DMD5_ODBC -DODBCINSTDIR='"/usr/local/pgsql/etc"'  -c -o odbcapi.o odbcapi.c 
gcc -O2 -pipe -m486 -Wall -Wmissing-prototypes -Wmissing-declarations -g -O0 -Wall -Wmissing-prototypes
-Wmissing-declarations-Wpointer-arith -Wcast-align -fpic -I. -I../../../src/include -I/usr/local/include/readline
-I/usr/contrib/include-DFRONTEND -DMD5_ODBC -DODBCINSTDIR='"/usr/local/pgsql/etc"'  -c -o multibyte.o multibyte.c 
multibyte.c:64: warning: no previous prototype for `pg_ismb'
multibyte.c: In function `pg_CS_stat':
multibyte.c:232: warning: suggest parentheses around && within ||
gcc -O2 -pipe -m486 -Wall -Wmissing-prototypes -Wmissing-declarations -g -O0 -Wall -Wmissing-prototypes
-Wmissing-declarations-Wpointer-arith -Wcast-align -fpic -I. -I../../../src/include -I/usr/local/include/readline
-I/usr/contrib/include-DFRONTEND -DMD5_ODBC -DODBCINSTDIR='"/usr/local/pgsql/etc"'  -c -o gpps.o gpps.c 
ar cr libpsqlodbc.a `lorder info.o bind.o columninfo.o connection.o convert.o drvconn.o environ.o execute.o lobj.o
md5.omisc.o options.o pgtypes.o psqlodbc.o qresult.o results.o socket.o parse.o statement.o tuple.o tuplelist.o
dlg_specific.oodbcapi.o multibyte.o gpps.o | tsort`