Re: Fix DROP PROPERTY GRAPH "unsupported object class" error - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Fix DROP PROPERTY GRAPH "unsupported object class" error
Date
Msg-id 200148.1780878520@sss.pgh.pa.us
Whole thread
In response to Re: Fix DROP PROPERTY GRAPH "unsupported object class" error  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Michael Paquier <michael@paquier.xyz> writes:
> + property graph element label  |        |      | e of e of
> create_property_graph_tests.gt
> + property graph element label  |        |      | v1 of v1 of
> create_property_graph_tests.gt
> + property graph element label  |        |      | v2 of v2 of
> create_property_graph_tests.gt
> [...]
> + property graph label property |        |      | c of e of e of
> create_property_graph_tests.gt
> + property graph label property |        |      | k1 of e of e of
> create_property_graph_tests.gt
> + property graph label property |        |      | k2 of e of e of
> create_property_graph_tests.gt

> FWIW, I still find these descriptions written as of "$object of
> $object of..", or worse the "$object1 of $object2 of $object2 of..",
> really hard to parse, and make some sense out of them.  Am I the only
> one?

No.  At the very least, these messages violate our style guidelines [1]:

    Type of the Object

    When citing the name of an object, state what kind of object it is.

    Rationale: Otherwise no one will know what “foo.bar.baz” refers to.

I'm not sure whether adding that would be sufficient to make these
intelligible, but surely it would help.  I think your first example
would come out like

    label e of property(?) e of property graph create_property_graph_tests.gt

            regards, tom lane

[1] https://www.postgresql.org/docs/current/error-style-guide.html#ERROR-STYLE-GUIDE-OBJECT-TYPE



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Fix comment in report_sequence_errors()
Next
From: jian he
Date:
Subject: Re: Fix domain fast defaults on empty tables