Re: psql misbehaves because of a simple typo - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: psql misbehaves because of a simple typo
Date
Msg-id 200112280435.fBS4ZD026808@candle.pha.pa.us
Whole thread Raw
In response to Re: psql misbehaves because of a simple typo  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: psql misbehaves because of a simple typo
List pgsql-hackers
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > OK, so what do we want to do?  Clearing the buffer on a any backslash
> > command is clearly not what we want to do.  Should we clear the buffer
> > on a backslash command _only_ if the number of paren's is not even?  If
> > we don't clear the counter on a backslash command with uneven parens, do
> > we risk trapping people in psql?
> 
> "Trap"?  AFAIK \q works in any case.
> 
> \r should reset both the buffer and the counter, and seems to do so,
> though I'm not quite seeing where it manages to accomplish the latter
> (command.c only resets query_buf).  \e should probably provoke a

See mainloop.c, line 450.  Any backshash command resets the counter.

> recomputation of paren_level after the edit occurs.  Offhand I do not
> think that any other backslash commands should reset either the buffer
> or the counter.  Peter, your thoughts?

Re-doing it for the editor is interesting.  The other items like quotes
and stuff should also probably be recomputed too.

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026
 


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: psql misbehaves because of a simple typo
Next
From: Bruce Momjian
Date:
Subject: Re: psql misbehaves because of a simple typo