Re: Undocumented feature costs a lot of performance in COPY - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: Undocumented feature costs a lot of performance in COPY
Date
Msg-id 200112042118.fB4LIYL07607@candle.pha.pa.us
Whole thread Raw
In response to Re: Undocumented feature costs a lot of performance in COPY IN  (Doug McNaught <doug@wireboard.com>)
List pgsql-hackers
> Tom Lane <tgl@sss.pgh.pa.us> writes:
> 
> > and indeed, only the first character is used by COPY OUT.  But COPY IN
> > is presently coded so that if multiple characters are mentioned in
> > USING DELIMITERS, any one of them will be taken as a field delimiter.
> > 
> > I would like to change the code to just "if (c == delim[0])",
> > which should buy back most of that 20% and make the behavior match the
> > documentation.  Question for the list: is this a bad change?  Is anyone
> > out there actually using this undocumented behavior?
> 
> Not I.
> 
> As an utter nitpick, the syntax should IMHO be USING DELIMITER (no S)
> if there is only one possible delimiter character.  But that *would*
> break lots of apps so I don't advocate it.  ;)

We could support keywords DELIMITER and DELIMITERS and only document the first
one.

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026
 


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [ADMIN] compression -Fx "problem"
Next
From: Peter Eisentraut
Date:
Subject: Re: date formatting and tab-complete patch